-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Any for unsized types #30928
Conversation
This is a bit weird since unsized types can't be used in trait objects, but Any is *also* used as pure marker trait since Reflect isn't stable. There are many cases (e.g. TypeMap) where all you need is a TypeId.
I have a vague inkling that we intentionally didn't do this in the past, but trying to recall the reason as to why I have no idea. As a result I'd be fine with this, but would like another sign-off as well. |
📌 Commit 5d2275d has been approved by |
⌛ Testing commit 5d2275d with merge 41589a8... |
💔 Test failed - auto-mac-64-nopt-t |
@bors: retry On Sat, Jan 16, 2016 at 12:20 AM, bors notifications@github.com wrote:
|
⌛ Testing commit 5d2275d with merge 21b8880... |
💔 Test failed - auto-linux-64-nopt-t |
@bors: retry |
⌛ Testing commit 5d2275d with merge 373bc01... |
💔 Test failed - auto-linux-64-nopt-t |
@bors: retry |
This is a bit weird since unsized types can't be used in trait objects, but Any is *also* used as pure marker trait since Reflect isn't stable. There are many cases (e.g. TypeMap) where all you need is a TypeId. r? @aturon
This is a bit weird since unsized types can't be used in trait objects,
but Any is also used as pure marker trait since Reflect isn't stable.
There are many cases (e.g. TypeMap) where all you need is a TypeId.
r? @aturon