Change some helps to suggestions #31053
Conversation
|
No tests? |
Manishearth
force-pushed
the
help_suggestions
branch
from
8f05786 to
de82599
Compare
|
Pushed the test fixes. |
Manishearth
force-pushed
the
help_suggestions
branch
from
de82599 to
4a9a568
Compare
|
oh, the issue is that the other suggestion is hard to trigger, not sure the context in which resolve is set to emit_errors=false |
| "E0519"); | ||
| if let Ok(snip) = cx.sess().codemap().span_to_snippet(lit_span) { | ||
| err.span_suggestion(span, "try using a cast or the `!` operator:", | ||
| format!("!{}", snip)); |
There was a problem hiding this comment.
I think the cast way is the only one you can do generically. as -1isize as usize does not yield the same as !1usize. It would need to be !(x-1), which errors if x == 0
There was a problem hiding this comment.
Huh. Adding a generic cast here is harder so I'll just fix up the help message.
|
☔ The latest upstream changes (presumably #31010) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Given that the unsigned one doesn't have a generic suggestion and the other one can't be triggered, closing |
r? @eddyb