Skip to content

RefCell::borrow_mut example should demonstrate mut #31192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2016

Conversation

frewsxcv
Copy link
Member

No description provided.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

/// {
/// let mut borrowed_cell = c.borrow_mut();
/// *borrowed_cell = 7;
/// }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this could just be:

*c.borrow_mut() = 7;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@alexcrichton
Copy link
Member

@bors: r+ a193536

@steveklabnik
Copy link
Member

@bors: rollup

Manishearth added a commit to Manishearth/rust that referenced this pull request Jan 26, 2016
bors added a commit that referenced this pull request Jan 26, 2016
@bors bors merged commit a193536 into rust-lang:master Jan 26, 2016
@frewsxcv frewsxcv deleted the patch-27 branch January 26, 2016 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants