Allow #[repr(i32)] for univariant enum #31232
Conversation
```
#[repr(i32)]
enum Univariant {
X = 17
}
```
Fixes rust-lang#10292
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -4250,14 +4250,9 @@ pub fn check_enum_variants<'a,'tcx>(ccx: &CrateCtxt<'a,'tcx>, | |||
| let def_id = ccx.tcx.map.local_def_id(id); | |||
| let hint = *ccx.tcx.lookup_repr_hints(def_id).get(0).unwrap_or(&attr::ReprAny); | |||
|
|
|||
| if hint != attr::ReprAny && vs.len() <= 1 { | |||
| if vs.len() == 1 { | |||
| span_err!(ccx.tcx.sess, sp, E0083, | |||
There was a problem hiding this comment.
You should remove E0083 along with this change
|
I am amazed this worked without changes to trans. cc @rust-lang/compiler and @luqmana r+ if no one objects and with the error description removed. |
stepancheg
force-pushed
the
enum-univariant
branch
from
6c2f78f
to
69c6292
Compare
|
Removed E0083. |
|
Why was this ever illegal in the first place? It makes no sense to me. |
|
Yea, looks good to me. Not sure why it was disallowed but should be fine if it builds and passes tests. |
| span_err!(ccx.tcx.sess, sp, E0084, | ||
| "unsupported representation for zero-variant enum"); | ||
| }; | ||
| if hint != attr::ReprAny && vs.len() == 0 { |
stepancheg
force-pushed
the
enum-univariant
branch
from
69c6292
to
641267e
Compare
|
Updated with |
|
No objections. |
|
The reason this doesn't require any |
|
Thanks all! (And especially @stepancheg for the PR in the first place and some patience for the r+). @bors: r+ |
|
📌 Commit 641267e has been approved by |
```
enum Univariant {
X = 17
}
```
Fixes #10292
Fixes #10292