Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move middle::check_match and middle::const_eval to their own crate #31255

Closed
wants to merge 2 commits into from

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jan 28, 2016

r? @arielb1

this is groundwork for replacing const eval (running on HIR) by a constant propagator (running on MIR)

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@oli-obk oli-obk force-pushed the check_match branch 2 times, most recently from 8843a5f to 6f4dc87 Compare January 29, 2016 08:55
@arielb1
Copy link
Contributor

arielb1 commented Jan 31, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Jan 31, 2016

📌 Commit 6f4dc87 has been approved by arielb1

@bors
Copy link
Contributor

bors commented Jan 31, 2016

🔒 Merge conflict

@bors
Copy link
Contributor

bors commented Jan 31, 2016

☔ The latest upstream changes (presumably #31298) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk
Copy link
Contributor Author

oli-obk commented Feb 1, 2016

was just a change in error codes right next to one of the moved error codes

@oli-obk
Copy link
Contributor Author

oli-obk commented Feb 3, 2016

let's delay this until after typestrong const ints

@oli-obk oli-obk closed this Feb 3, 2016
@oli-obk oli-obk deleted the check_match branch March 15, 2016 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants