Fix E0118 #31347
Merged
Fix E0118 #31347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ``` | ||
| impl SomeTypeThatDoesntExist { } | ||
| type NineString = &'static [char]; |
There was a problem hiding this comment.
The type alias seems superfluous, and it's irrelevant to the error itself.
There was a problem hiding this comment.
I'll also say that you can't implement a type which isn't defined in the current crate.
There was a problem hiding this comment.
Type aliases don't change the situation at all, they're just confusing here since it seems like you're suggesting them as a solution even if they won't work.
|
cc @Manishearth |
GuillaumeGomez
force-pushed
the
fix_E0118
branch
4 times, most recently
from
171f3c0 to
994ed2a
Compare
| "no base type found for inherent implementation; \ | ||
| implement a trait or new type instead"); | ||
| "no base type found for inherent implementation; either \ | ||
| implement a trait on it or create a newtype to wrap it \ |
There was a problem hiding this comment.
the stuff after the semicolon should be in a help
GuillaumeGomez
force-pushed
the
fix_E0118
branch
from
994ed2a to
3446898
Compare
| "no base type found for inherent implementation; \ | ||
| implement a trait or new type instead"); | ||
| "no base type found for inherent implementation;"); | ||
| span_help!(self.tcx.sess, item.span, |
There was a problem hiding this comment.
The two should be linked using struct_span_err.
GuillaumeGomez
force-pushed
the
fix_E0118
branch
from
3446898 to
db63a55
Compare
|
Updated. |
|
@bors r+ |
|
📌 Commit db63a55 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 2, 2016
bors
added a commit
that referenced
this pull request
Feb 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @eddyb