Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking batch] don't glob-export syntax::abi enums #31485

Closed
wants to merge 2 commits into from

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Feb 8, 2016

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Manishearth
Copy link
Member

While we're at it, should we also un-batch export TyFoo and ExprBar and friends from AST/HIR?

@Manishearth
Copy link
Member

cc @erickt heads up

@oli-obk
Copy link
Contributor Author

oli-obk commented Feb 8, 2016

I'm creating a bunch of these PRs, then you can roll them up. Feels free to open an issue with checkboxes of things that should be done, in an order that your prefer.

@Manishearth
Copy link
Member

Nah, this works

@Manishearth
Copy link
Member

r+ on this one

@bluss
Copy link
Member

bluss commented Feb 8, 2016

Should it have the ususal [breaking-change] marker in the commit log or PR message? That's the usual marker.

@Manishearth
Copy link
Member

the [breaking-batch] is for batching up breaking libsyntax changes

@bluss
Copy link
Member

bluss commented Feb 8, 2016

Is this a breaking change in the usual sense of [breaking-change]? Then it should have that tag.

@Manishearth
Copy link
Member

Well, breaking libsyntax. Not sure if that qualifies as breaking; since many compiler changes break internals and we don't mark that as breaking either.

@oli-obk
Copy link
Contributor Author

oli-obk commented Feb 8, 2016

I'll mark it. Abi can show up in compiler plugins

@oli-obk
Copy link
Contributor Author

oli-obk commented Feb 8, 2016

merged into #31487

@oli-obk oli-obk closed this Feb 8, 2016
@oli-obk oli-obk deleted the breaking-batch/syntax/abi branch June 15, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants