driver: Disallow predicates in --cfg specs #31499
Conversation
|
r? @brson |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| } | ||
|
|
||
| if sopts.cfg.iter().any(|item| is_meta_list(&*item)) { | ||
| early_error(output, "predicates are not allowed in --cfg"); |
There was a problem hiding this comment.
Not sure about error message, or if we should print the offending flags as well. Input welcome!
There was a problem hiding this comment.
How about something "invalid predicate in --cfg command line argument: foo(whatever)", printing the actual argument. That mirrors the in-source error a little better and says where the error is.
There was a problem hiding this comment.
Sounds good. I'll make the change after finding out how to print more than one error, since the user could have passed multiple offending flags. (This is my first time in the compiler's code.)
There was a problem hiding this comment.
Done in kamalmarhubi@c32c7c2
A spec like `#[cfg(foo(bar))]` is not allowed as an attribute. This makes the same spec be rejected by the compiler if passed in as a `--cfg` argument. Fixes rust-lang#31495
kamalmarhubi
force-pushed
the
cfg-flag-invalid-cfgs
branch
from
db425a4 to
6d2c866
Compare
|
@brson any thoughts on whether the check should be in the |
|
@kamalmarhubi early. @bors r+ Thanks! |
|
📌 Commit c32c7c2 has been approved by |
A spec like `#[cfg(foo(bar))]` is not allowed as an attribute. This makes the same spec be rejected by the compiler if passed in as a `--cfg` argument. Fixes #31495
A spec like
#[cfg(foo(bar))]is not allowed as an attribute. Thismakes the same spec be rejected by the compiler if passed in as a
--cfgargument.Fixes #31495