[breaking batch] Remove some unnecessary indirection from AST structures #31583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ LGTM. Not sure why Annotatable still uses P, but that's okay. |
|
📌 Commit 77cc576 has been approved by |
|
Huh, it seems like without prioritizing two PRs approved roughly at the same time have to be extremely lucky to end up in the same nightly. |
|
@bors p=10 shit sorry, I forgot |
bors
added a commit
that referenced
this pull request
Feb 12, 2016
cc #31487 plugin-[breaking-change] The AST part of #30087 r? @Manishearth
eddyb
reviewed
Feb 15, 2019
| @@ -65,6 +65,10 @@ impl<T: 'static> P<T> { | |||
| { | |||
| f(*self.ptr) | |||
| } | |||
| /// Equivalent to and_then(|x| x) | |||
| pub fn unwrap(self) -> T { | |||
There was a problem hiding this comment.
Wow I'm years late to this but see #54277 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #31487
plugin-[breaking-change]
The AST part of #30087
r? @Manishearth