Move FulfillmentContext out of InferCtxt #31588
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
cc @jroesch |
|
Very nice @soltanmm. It's true that the PR that moved it out was big, but I think it was doing other things at the same time. In any case, I don't think you're missing anything. |
|
@bors r+ |
|
📌 Commit 0ff7021 has been approved by |
<sup>**context:** moving back to a layered approach to type checking.</sup> It looks like they'd not ended up tightly coupled in the time one was owned by the other. Every instance outside of `FnCtxt.inh` was from an `InferCtxt` created and dropped in the same function body. This conflicts slightly with #30652, but there too it looks like the `FulfillmentContext` is from an `InferCtxt` that is created and dropped within the same function body (across one call to a module-private function). That said, I heard that the PR that originally moved `FulfillmentContext` into `InferCtxt` was big, which leaves me concerned that I'm missing something. r? @nikomatsakis
context: moving back to a layered approach to type checking.
It looks like they'd not ended up tightly coupled in the time one was owned by the other. Every instance outside of
FnCtxt.inhwas from anInferCtxtcreated and dropped in the same function body.This conflicts slightly with #30652, but there too it looks like the
FulfillmentContextis from anInferCtxtthat is created and dropped within the same function body (across one call to a module-private function).That said, I heard that the PR that originally moved
FulfillmentContextintoInferCtxtwas big, which leaves me concerned that I'm missing something.r? @nikomatsakis