-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #31693
Closed
Closed
Rollup of 6 pull requests #31693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Manishearth
commented
Feb 16, 2016
- Successful merges: Add lint to check that all crates have #![unstable] #31627, doc pages: add the ability to search unknown types #31639, Clarify memory structure of vectors in documentation #31666, std: use more LFS functions on Linux #31668, Fix wrong help message left in #31368 #31678, Global error explanations improvements #31679
- Failed merges:
This enables `*` in all type positions in doc searches, which I often want in order to find functions that create or convert specific types (e.g. `* -> vec`) but I don't actually know what kinds of input they expect. I actually started working on this because of rust-lang#31598, but I've wanted it several times when exploring new crates.
Closes rust-lang#31554. Contributes to rust-lang#29380.
…-types, r=alexcrichton This enables `*` in all type positions in doc searches, which I often want in order to find functions that create or convert specific types (e.g. `* -> vec`) but I don't actually know what kinds of input they expect. I actually started working on this because of rust-lang#31598, but I've wanted it several times when exploring new crates.
…t-in-vec-docs, r=steveklabnik Tweak documentation to clarify the structure of `Vec`s as contiguous arrays of items in memory. Closes rust-lang#31554; contributes to rust-lang#29380. r? @steveklabnik
This follows the pattern already used for stat functions from rust-lang#31551. Now `ftruncate`, `lseek`, and `readdir_r` use their explicit 64-bit variants for LFS support, using wider `off_t` and `dirent` types. This also updates to `open64`, which uses no different types but implies the `O_LARGEFILE` flag. Non-Linux platforms just map their normal functions to the 64-bit names. r? @alexcrichton
…xcrichton Thanks for catching this @tamird. Here's a quick fix. I didn't pick "let the linker link dead code" or "link dead code" because it would add no extra information to the flag name. Here's a another proposal. r? @alexcrichton
…on, r=Manishearth r? @Manishearth
@bors r+ p=10 force |
📌 Commit 171c4a4 has been approved by |
@bors force |
1 similar comment
@bors force |
homu is somehow not able to fetch mergeability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.