Rustdoc: add crate items to the search-index #31715
Conversation
|
r? @cmr (rust_highfive has picked a reviewer for you, use r? to override) |
| fn to_json(&self) -> Json { | ||
| let mut data = BTreeMap::new(); | ||
| data.insert("name".to_owned(), self.name.to_json()); | ||
| Json::Object(data) |
There was a problem hiding this comment.
This seems different than it was before? Just double-checking that it was accounted for on the search index side of things
|
Sorry this took awhile to get around to, but thanks @mitaa! I like the cleanup going on here, definitely improves readability. I've got just one minor question about how the search index looks like it's changed, but other than that looks good to me. |
mitaa
force-pushed
the
rdoc-index-crate
branch
from
e743770 to
81f673d
Compare
|
You're right, I've changed that part back to the old behaviour - the search index shouldn't have changed but it's probably safer this way. (like the comment said the |
This allows to search for crates in documentation and simplifies the json serialization of the search-index. fixes #14077
|
💔 Test failed - auto-win-gnu-64-nopt-t |
|
@bors: retry On Mon, Feb 22, 2016 at 4:51 PM, bors notifications@github.com wrote:
|
|
⚡ Previous build results for auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-ios-opt, auto-win-gnu-64-opt are reusable. Rebuilding only auto-linux-64-debug-opt, auto-mac-32-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-msvc-32-opt, auto-win-msvc-64-opt... |
This allows to search for crates in documentation and simplifies the json serialization of the search-index.
fixes #14077