Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error[E0518] not displayed for #[inline] on structs inside fns #31775

Merged
merged 1 commit into from
Feb 20, 2016

Conversation

nxnfufunezn
Copy link
Contributor

Fixes : #31769
r? @eddyb

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@eddyb
Copy link
Member

eddyb commented Feb 19, 2016

LGTM, but it needs a compile-fail test, something along the lines of:

fn main() {
    #[inline] struct Foo;
    #[repr(C)] fn foo() {}
}

Both of those compile right now and neither is valid.

@nxnfufunezn
Copy link
Contributor Author

oops! I always forget about tests..

@nxnfufunezn
Copy link
Contributor Author

@eddyb

@eddyb
Copy link
Member

eddyb commented Feb 19, 2016

@bors r+ rollup Thanks!

@bors
Copy link
Contributor

bors commented Feb 19, 2016

📌 Commit 27f8c53 has been approved by eddyb

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Feb 19, 2016
bors added a commit that referenced this pull request Feb 19, 2016
@jonas-schievink
Copy link
Contributor

Just noting that this is technically a [breaking-change] (with probably no impact)

bors added a commit that referenced this pull request Feb 20, 2016
@bors bors merged commit 27f8c53 into rust-lang:master Feb 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants