Revert ObligationForest on beta branch #31851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, r=aturon" This reverts commit c14b615, reversing changes made to dda25f2. This caused a regression in compiler performance and backporting the fix to beta was deemed too risky and too challenging, since it is non-trivial and builds on prior commits in various ways. Conflicts: src/librustc/middle/traits/fulfill.rs src/librustc_data_structures/lib.rs
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
|
|
|
Hmm, local testing of this PR has encountered some odd failures (e.g., a segfault just now in the libcollections tests). But I am sort of reluctant to blame it on this PR to be honest. |
|
I'm testing locally. |
|
Actually, I see the same problem whether or not this commit is applied: |
|
I don't see the crash locally. |
|
OK, I don't know what's happening locally, but I'm inclined to take this PR. |
brson
added a commit
that referenced
this pull request
Feb 25, 2016
Revert ObligationForest on beta branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OF caused a regression in compiler performance and backporting the fix
to beta was deemed too risky and too challenging, since it is
non-trivial and builds on prior commits in various ways.