Skip to content

Rollup of 9 pull requests #31873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Feb 25, 2016
Merged

Rollup of 9 pull requests #31873

merged 20 commits into from
Feb 25, 2016

Conversation

ivan and others added 20 commits February 15, 2016 15:53
The methods don't return `size` slices, but rather slices of
`size` elements. Sorry!
I have made changes and built it after that. Please advise,

rust-lang#31820
…labnik

Reference implied that use declarations may appear *only* at the top of blocks and modules, but it is not the case, and the following is valid:

```Rust
fn foo() {
    let x = 92;
    use baz::bar;
}
```

r? @steveklabnik
As a Rust newbie, I found the book's explanation for why the `filter` closure gets a reference very confusing, and tried to figure out why `filter` is somehow less consumptive than `map` -- but it isn't; that's controlled by `iter`/`into_iter`.  I flailed around for a while until @habnabit explained it to me, and in retrospect it is quite obvious :-)
@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@Manishearth
Copy link
Member Author

@bors r+ p=20

@bors
Copy link
Collaborator

bors commented Feb 24, 2016

📌 Commit b660ca5 has been approved by Manishearth

@bors
Copy link
Collaborator

bors commented Feb 24, 2016

⌛ Testing commit b660ca5 with merge f6f050d...

bors added a commit that referenced this pull request Feb 24, 2016
@bors
Copy link
Collaborator

bors commented Feb 25, 2016

💔 Test failed - auto-win-gnu-32-nopt-t

@steveklabnik
Copy link
Member

@bors: retry

@bors
Copy link
Collaborator

bors commented Feb 25, 2016

💔 Test failed - auto-mac-64-nopt-t

@Manishearth
Copy link
Member Author

@bors retry

1 similar comment
@bors bors merged commit b660ca5 into rust-lang:master Feb 25, 2016
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.