-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std: Stabilize APIs for the 1.8 release #31928
Conversation
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
@@ -849,10 +854,18 @@ impl str { | |||
#[unstable(feature = "str_utf16", | |||
reason = "this functionality may only be provided by libunicode", | |||
issue = "27714")] | |||
#[rustc_deprecated(since = "1.8.0", reason = "renamed to encode_utf16")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Argh, this is another one of those cases where we don't really want the deprecation to go into effect on nightly until 1.8 is actually on the stable channel. This is probably used rarely enough that it doesn't matter, but we really need to get our story straight there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't that just for deprecating stable APIs? For deprecating unstable APIs everyone should be able to immediately switch, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gah, I make this mistake every time. Ignore me.
Yay, some very good stuff in this one! I left a few concerns here and there. |
c212509
to
ffef000
Compare
@bors: r=aturon ffef000f46147084000f7fd125335aaa043cedf3 |
|
⌛ Testing commit ffef000 with merge 18a736a... |
💔 Test failed - auto-win-msvc-32-opt |
fae5fcb
to
aa7c581
Compare
@bors: r=aturon aa7c581 |
⌛ Testing commit aa7c581 with merge c7a3250... |
💔 Test failed - auto-win-msvc-64-opt |
|
aa7c581
to
7dc363c
Compare
@bors: r=aturon 7dc363c |
⌛ Testing commit 7dc363c with merge 1573036... |
💔 Test failed - auto-linux-64-nopt-t |
This commit is the result of the FCPs ending for the 1.8 release cycle for both the libs and the lang suteams. The full list of changes are: Stabilized * `braced_empty_structs` * `augmented_assignments` * `str::encode_utf16` - renamed from `utf16_units` * `str::EncodeUtf16` - renamed from `Utf16Units` * `Ref::map` * `RefMut::map` * `ptr::drop_in_place` * `time::Instant` * `time::SystemTime` * `{Instant,SystemTime}::now` * `{Instant,SystemTime}::duration_since` - renamed from `duration_from_earlier` * `{Instant,SystemTime}::elapsed` * Various `Add`/`Sub` impls for `Time` and `SystemTime` * `SystemTimeError` * `SystemTimeError::duration` * Various impls for `SystemTimeError` * `UNIX_EPOCH` * `ops::{Add,Sub,Mul,Div,Rem,BitAnd,BitOr,BitXor,Shl,Shr}Assign` Deprecated * Scoped TLS (the `scoped_thread_local!` macro) * `Ref::filter_map` * `RefMut::filter_map` * `RwLockReadGuard::map` * `RwLockWriteGuard::map` * `Condvar::wait_timeout_with` Closes rust-lang#27714 Closes rust-lang#27715 Closes rust-lang#27746 Closes rust-lang#27748 Closes rust-lang#27908 Closes rust-lang#29866
This applies the same fix as added in 595d5b2 which is to just compile all valgrind tests statically instead of dynamically. It looks like this is a resurgence of either rust-lang#30383 or rust-lang#31328 in some weird fashion. I'm not actually sure what's going on with the bots, and it's unclear whether this is a valgrind bug or a libstd bug, but for now let's just get things landing again. Closes rust-lang#30383
7dc363c
to
95560c1
Compare
The most recent failure log matches the failures seen on #31335. These valgrind failures are unfortunately preventing things from landing, so we need a fix fr them soon. In 595d5b2 I fixed a test by adding I'm not really sure what's going on here with valgrind, but as part of this PR (to land it) I'm updating all tests to have that flag. This is gonna close #30383 but I'll open a new issue about tracking this. |
This commit is the result of the FCPs ending for the 1.8 release cycle for both the libs and the lang suteams. The full list of changes are: Stabilized * `braced_empty_structs` * `augmented_assignments` * `str::encode_utf16` - renamed from `utf16_units` * `str::EncodeUtf16` - renamed from `Utf16Units` * `Ref::map` * `RefMut::map` * `ptr::drop_in_place` * `time::Instant` * `time::SystemTime` * `{Instant,SystemTime}::now` * `{Instant,SystemTime}::duration_since` - renamed from `duration_from_earlier` * `{Instant,SystemTime}::elapsed` * Various `Add`/`Sub` impls for `Time` and `SystemTime` * `SystemTimeError` * `SystemTimeError::duration` * Various impls for `SystemTimeError` * `UNIX_EPOCH` * `ops::{Add,Sub,Mul,Div,Rem,BitAnd,BitOr,BitXor,Shl,Shr}Assign` Deprecated * Scoped TLS (the `scoped_thread_local!` macro) * `Ref::filter_map` * `RefMut::filter_map` * `RwLockReadGuard::map` * `RwLockWriteGuard::map` * `Condvar::wait_timeout_with` Closes #27714 Closes #27715 Closes #27746 Closes #27748 Closes #27908 Closes #29866 Closes #28235 Closes #29720
Tracking issue: #31968 |
This commit is the result of the FCPs ending for the 1.8 release cycle for both
the libs and the lang suteams. The full list of changes are:
Stabilized
braced_empty_structs
augmented_assignments
str::encode_utf16
- renamed fromutf16_units
str::EncodeUtf16
- renamed fromUtf16Units
Ref::map
RefMut::map
ptr::drop_in_place
time::Instant
time::SystemTime
{Instant,SystemTime}::now
{Instant,SystemTime}::duration_since
- renamed fromduration_from_earlier
{Instant,SystemTime}::elapsed
Add
/Sub
impls forTime
andSystemTime
SystemTimeError
SystemTimeError::duration
SystemTimeError
UNIX_EPOCH
ops::{Add,Sub,Mul,Div,Rem,BitAnd,BitOr,BitXor,Shl,Shr}Assign
Deprecated
scoped_thread_local!
macro)Ref::filter_map
RefMut::filter_map
RwLockReadGuard::map
RwLockWriteGuard::map
Condvar::wait_timeout_with
Closes #27714
Closes #27715
Closes #27746
Closes #27748
Closes #27908
Closes #29866
Closes #28235
Closes #29720