Integrate privacy into field and method selection #31938

jseyfried · 2016-02-27T09:18:28Z

This PR integrates privacy checking into field and method selection so that an inaccessible field/method cannot stop an accessible field/method from being used (fixes #12808 and fixes #22684).
r? @eddyb

jseyfried · 2016-02-27T09:22:36Z

cc @nikomatsakis @petrochenkov

nikomatsakis · 2016-03-02T21:39:57Z

On Sat, Feb 27, 2016 at 01:23:08AM -0800, Jeffrey Seyfried wrote:

cc @nikomatsakis @petrochenkov

you're on a roll! Just FYI I sat down over last few days to read over
some of your changes to resolve in detail, because I realize I've kind
of lost track of how things are working, and am starting to feel
uncomfortable reviewing :) hoping to finish that up tonight though

jseyfried · 2016-03-02T23:57:57Z

@nikomatsakis Ok, let me know if you'd like me to explain or comment anything!

jseyfried · 2016-03-11T00:11:27Z

Fixes #22684

eddyb · 2016-03-11T00:12:48Z

@jseyfried you need to put that in the description.

jseyfried · 2016-03-11T00:17:38Z

@eddyb I updated the description.

jseyfried · 2016-03-16T03:05:38Z

I rebased and added a commit that refactors away most of the privacy visitor.

bors · 2016-03-27T02:50:27Z

☔ The latest upstream changes (presumably #32432) made this pull request unmergeable. Please resolve the merge conflicts.

nikomatsakis · 2016-03-27T09:10:58Z

@jseyfried can you add some tests that show that the logic about private fields/methods is working? I was thinking it'd be nice to have a test where the private field appears in an outer deref. In other words, if the autoderef chain of types is A -> B -> C, then the field/method is on type A or B.

r=me with such a test.

nikomatsakis · 2016-03-27T09:13:26Z

src/test/compile-fail/autoderef-privacy.rs

+fn f(bar: foo::Bar, baz: foo::Baz) {
+ let _ = bar.i;
+ let _ = baz.0;
+ let _ = bar.f();


can you convert this to a run-pass test and somehow check the return value of f, so that we know the right function is being called?

nikomatsakis · 2016-03-27T09:18:08Z

Sorry, let me clarify my previous comment. I'd like to see two things:

Modify the existing test for private fields/methods to be run-pass, and using some logic that proves we are picking the right fields.
- Maybe also extend the test to read from the fields in a context where it should pick the private one, and prove that this logic is working correctly.
A test specifically targeting the case where only a private field/method is available, which would target the logic you put in around that case.

jseyfried · 2016-03-30T21:57:38Z

@nikomatsakis

Modify the existing test for private fields/methods to be run-pass, and using some logic that proves we are picking the right fields.

Maybe also extend the test to read from the fields in a context where it should pick the private one, and prove that this logic is working correctly.

Done.

A test specifically targeting the case where only a private field/method is available

Private inherent methods are tested in private-method-inherited (and others) and I amended struct-field-privacy to test private positional fields as well as private named fields.

I believe these tests are sufficient to check the logic you referenced, but if you want I can add a compile-fail test where there is only a private field/method in a non-trivial autoderef chain.

nikomatsakis · 2016-03-30T23:51:16Z

@jseyfried I'll leave it to your judgement. I certainly lean towards more exhaustive testing but there is no reason to add duplicate tests either. R=me either way.

jseyfried · 2016-03-31T00:29:41Z

Ok, thanks for reviewing!

@bors r=nikomatsakis

bors · 2016-03-31T00:29:42Z

📌 Commit 48c20b0 has been approved by nikomatsakis

bors · 2016-03-31T01:56:58Z

⌛ Testing commit 48c20b0 with merge 4f46ecb...

@eddyb

Integrate privacy into field and method selection This PR integrates privacy checking into field and method selection so that an inaccessible field/method can not stop an accessible field/method from being used (fixes #12808 and fixes #22684). r? @eddyb

bors · 2016-03-31T04:13:42Z

💔 Test failed - auto-mac-32-opt

jseyfried · 2016-03-31T04:17:37Z

@bors retry

alexcrichton · 2016-03-31T16:04:56Z

@bors: retry force clean

alexcrichton · 2016-03-31T16:09:32Z

@bors: retry force clean

maybe second time's the charm?

bors · 2016-03-31T16:09:35Z

⌛ Testing commit 48c20b0 with merge 3399d19...

@eddyb

Integrate privacy into field and method selection This PR integrates privacy checking into field and method selection so that an inaccessible field/method can not stop an accessible field/method from being used (fixes #12808 and fixes #22684). r? @eddyb

bors · 2016-03-31T19:51:11Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-64-x-armhf, auto-linux-64-x-armsf, auto-linux-64-x-freebsd, auto-linux-64-x-netbsd, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild

rust-highfive assigned eddyb Feb 27, 2016

jseyfried force-pushed the autoderef_privacy branch 4 times, most recently from 9be5455 to 5d2e258 Compare February 28, 2016 00:35

jseyfried force-pushed the autoderef_privacy branch 3 times, most recently from 2f835d1 to 12a209b Compare March 3, 2016 07:47

jseyfried mentioned this pull request Mar 6, 2016

Fix incorrect trait privacy error #32073

Merged

jseyfried mentioned this pull request Mar 11, 2016

A strange processing methods visibility #22684

Closed

jseyfried force-pushed the autoderef_privacy branch from 4f16e1c to 6166bd7 Compare March 16, 2016 02:52

jseyfried force-pushed the autoderef_privacy branch from 3ae768d to f2c3d11 Compare March 25, 2016 07:10

jseyfried force-pushed the autoderef_privacy branch from f2c3d11 to 228fd48 Compare March 27, 2016 03:32

nikomatsakis self-assigned this Mar 27, 2016

nikomatsakis reviewed Mar 27, 2016
View reviewed changes

jseyfried force-pushed the autoderef_privacy branch from 228fd48 to 67b39f8 Compare March 27, 2016 22:17

jseyfried added 2 commits March 30, 2016 21:26

Autoderef privacy for fields

62d181f

Autoderef privacy for methods

6f16c5c

jseyfried and others added 5 commits March 30, 2016 21:26

Fix fallout in tests

09af503

Add tests for rust-lang#12808 and rust-lang#22684

8762fc3

Clean up the privacy visitor

48b048d

privacy: Cleanup check_field

38bef43

Improve tests

48c20b0

jseyfried force-pushed the autoderef_privacy branch from 67b39f8 to 48c20b0 Compare March 30, 2016 21:29

bors merged commit 48c20b0 into rust-lang:master Mar 31, 2016

This was referenced Mar 31, 2016

librustc: Add bug!(), bug_span!() macros as unified entry points for internal compiler errors #32562

Merged

Reorganize rustc_front into rustc::hir. #32570

Merged

bluss added the relnotes Marks issues that should be documented in the release notes of the next release. label Apr 5, 2016

jseyfried deleted the autoderef_privacy branch September 27, 2016 08:44

jseyfried mentioned this pull request Dec 22, 2016

Use DefIds instead of NodeIds for pub(restricted) visibilities #38490

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate privacy into field and method selection #31938

Integrate privacy into field and method selection #31938

jseyfried commented Feb 27, 2016 •

edited

Loading

jseyfried commented Feb 27, 2016

nikomatsakis commented Mar 2, 2016

jseyfried commented Mar 2, 2016

jseyfried commented Mar 11, 2016

eddyb commented Mar 11, 2016

jseyfried commented Mar 11, 2016

jseyfried commented Mar 16, 2016

bors commented Mar 27, 2016

nikomatsakis commented Mar 27, 2016

nikomatsakis Mar 27, 2016

jseyfried Mar 30, 2016

nikomatsakis commented Mar 27, 2016

jseyfried commented Mar 30, 2016

nikomatsakis commented Mar 30, 2016

jseyfried commented Mar 31, 2016

bors commented Mar 31, 2016

bors commented Mar 31, 2016

bors commented Mar 31, 2016

jseyfried commented Mar 31, 2016

alexcrichton commented Mar 31, 2016

alexcrichton commented Mar 31, 2016

bors commented Mar 31, 2016

bors commented Mar 31, 2016

Integrate privacy into field and method selection #31938

Integrate privacy into field and method selection #31938

Conversation

jseyfried commented Feb 27, 2016 • edited Loading

jseyfried commented Feb 27, 2016

nikomatsakis commented Mar 2, 2016

jseyfried commented Mar 2, 2016

jseyfried commented Mar 11, 2016

eddyb commented Mar 11, 2016

jseyfried commented Mar 11, 2016

jseyfried commented Mar 16, 2016

bors commented Mar 27, 2016

nikomatsakis commented Mar 27, 2016

nikomatsakis Mar 27, 2016

Choose a reason for hiding this comment

jseyfried Mar 30, 2016

Choose a reason for hiding this comment

nikomatsakis commented Mar 27, 2016

jseyfried commented Mar 30, 2016

nikomatsakis commented Mar 30, 2016

jseyfried commented Mar 31, 2016

bors commented Mar 31, 2016

bors commented Mar 31, 2016

bors commented Mar 31, 2016

jseyfried commented Mar 31, 2016

alexcrichton commented Mar 31, 2016

alexcrichton commented Mar 31, 2016

bors commented Mar 31, 2016

bors commented Mar 31, 2016

jseyfried commented Feb 27, 2016 •

edited

Loading