Explicitly opt out of Sync for cell and mpsc types
#31982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @apasel422! I wonder if it might also be a good idea to add compile-fail tests for these error messages as well? That way we can at least try to ensure the message remains high-quality over time. |
| @@ -307,6 +310,9 @@ pub struct Iter<'a, T: 'a> { | |||
| rx: &'a Receiver<T> | |||
| } | |||
|
|
|||
| #[stable(feature = "rust1", since = "1.0.0")] | |||
| impl<'a, T> !Sync for Iter<'a, T> { } | |||
There was a problem hiding this comment.
Perhaps this and the IntoIter can be left off? They seem less "fundamentally not-Sync" than the other types.
These types were already `!Sync`, but this improves error messages when they are used in contexts that require `Sync`, aligning them with conventions used with `Rc`, among others.
|
@alexcrichton Updated. |
|
This is a great change! The previous error message was pretty bad and a common source of new user confusion. |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 2, 2016
These types were already `!Sync`, but this improves error messages when they are used in contexts that require `Sync`, aligning them with conventions used with `Rc`, among others. r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These types were already
!Sync, but this improves error messages when they are used in contexts that requireSync, aligning them with conventions used withRc, among others.r? @alexcrichton