Fix note for type alias in trait position

[vegai]

Fix note for type alias in trait position

Fixes #31686

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[Manishearth]

You'll need to update the tests too. tests/compile-fail/issue-5035.rs will need a //~^^ NOTE: marker with the second note

You can check the test locally by running make check-stage1-cfail TESTNAME=issue-5035

Let a complete compile-fail run go through as well (make check-stage1-cfail) to ensure that other tests aren't affected.

[vegai]

Yep, also issue-3907.rs broke. Fixed'em both.

[Manishearth]

@bors r+

Thanks!

[bors]

📌 Commit 01a6e86 has been approved by Manishearth

[bluss]

I edited the PR title and the PR message, so that a small description of the change lands in the merge message.

[bors]

⌛ Testing commit 01a6e86 with merge 7b0b80a...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt