truncate i8-s to i1-s when loading constants #32032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| llvm::LLVMGetInitializer(v) | ||
| let d = unsafe { llvm::LLVMGetInitializer(v) }; | ||
| if t.is_bool() { | ||
| unsafe { llvm::LLVMConstTrunc(d, Type::i1(cx).to_ref()) } |
There was a problem hiding this comment.
Isn't there something similar in base::load_ty, using LLVMGetInitializer?
There was a problem hiding this comment.
This is a variant of load_ty that uses the const llvm functions.
There was a problem hiding this comment.
Nevermind, load_ty already handles this correctly via to_arg_ty.
|
@bors r+ |
|
📌 Commit cf29344 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 4, 2016
bors
added a commit
that referenced
this pull request
Mar 4, 2016
arielb1
added
beta-nominated
|
nominating for beta since this fixes a regression. |
nikomatsakis
added
the
beta-accepted
brson
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30891
r? @eddyb