cover more linux targets in libstd cargobuild #32132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Collaborator
|
⌛ Testing commit dbe2389 with merge aef46ac... |
Collaborator
|
💔 Test failed - auto-mac-64-opt |
Member
|
@bors: retry On Fri, Mar 11, 2016 at 1:38 AM, bors notifications@github.com wrote:
|
Collaborator
bors
added a commit
that referenced
this pull request
Mar 11, 2016
cover more linux targets in libstd cargobuild libstd/build.rs checked the target name against `"unknown-linux"`... That doesn't necessarily apply to all Linux targets as some toolchains for embedded targets will change that `unknown` field to some vendor name. Some shifting around was needed since Android is also a Linux target. r? @alexcrichton
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libstd/build.rs checked the target name against
"unknown-linux"... That doesn't necessarily apply to all Linux targets as some toolchains for embedded targets will change thatunknownfield to some vendor name. Some shifting around was needed since Android is also a Linux target.r? @alexcrichton