fmt: Reexport Alignment (unstable) #32187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Alignment` is returned by the unstable method Formatter::align. Without this change, the links to it in documentation are dead.
| @@ -38,6 +37,9 @@ pub use self::num::Radix; | |||
| pub use self::num::RadixFmt; | |||
| #[stable(feature = "debug_builders", since = "1.2.0")] | |||
| pub use self::builders::{DebugStruct, DebugTuple, DebugSet, DebugList, DebugMap}; | |||
| #[unstable(feature = "fmt_flags_align", reason = "method was just created", | |||
There was a problem hiding this comment.
Reason probably shouldn't mention method :P
|
So, to fill in a better reason, what is the reason this is still unstable? I'm not super sure from tracking issue #27726 |
|
This is actually also being done in #32133 which I think is what we'd prefer to do (redefine and translate vs reexport), but maybe that could be copied over here to land more quickly? |
|
Your way seems good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fmt: Reexport Alignment (unstable)
Alignmentis returned by the unstable method Formatter::align. Withoutthis change, the links to it in documentation are dead.