Skip to content

Statically link run-pass/command-before-exec so it passes not just whenever we happen to bootstrap perfectly. #32193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2016

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Mar 11, 2016

No description provided.

@eddyb
Copy link
Member Author

eddyb commented Mar 11, 2016

cc @rust-lang/tools This would probably not be a problem with rustbuild.

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 11, 2016

📌 Commit 5b7f430 has been approved by nikomatsakis

@alexcrichton
Copy link
Member

A fix I also suggested to @pnkfelix would be to just tag this with // no-prefer-dynamic to link it statically.

@Manishearth
Copy link
Member


failures:

---- [run-pass] run-pass/command-before-exec.rs stdout ----

error: test run failed!
status: exit code: 101
command: i686-apple-darwin/test/run-pass/command-before-exec.stage2-i686-apple-darwin 
stdout:
------------------------------------------

------------------------------------------
stderr:
------------------------------------------
thread '<main>' panicked at 'assertion failed: output.status.success()', /Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/src/test/run-pass/command-before-exec.rs:64
note: Run with `RUST_BACKTRACE=1` for a backtrace.

------------------------------------------

thread '[run-pass] run-pass/command-before-exec.rs' panicked at 'explicit panic', /Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/src/compiletest/runtest.rs:1651
note: Run with `RUST_BACKTRACE=1` for a backtrace.


failures:
    [run-pass] run-pass/command-before-exec.rs

@eddyb
Copy link
Member Author

eddyb commented Mar 12, 2016

@Manishearth What, the test is broken even at stage2?!

@eddyb
Copy link
Member Author

eddyb commented Mar 12, 2016

sigh reproduced locally. Time to use // no-prefer-dynamic.

EDIT: It appears to be the same parallelism nonsense I hit in #32080.
Oh and running make check-stage{1,2}-rpass -j2 breaks horribly. TIL.

EDIT2: Could also be bootstrapping failing to produce the same symbols.

@eddyb eddyb force-pushed the stage1-is-useful-mkay branch from 5b7f430 to 27217e5 Compare March 12, 2016 12:37
@eddyb eddyb changed the title Make check-stage1-rpass succeed by avoiding one problematic testcase. Statically link run-pass/command-before-exec so it passes not just whenever we happen to bootstrap perfectly. Mar 12, 2016
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 12, 2016

📌 Commit 27217e5 has been approved by nikomatsakis

@arielb1
Copy link
Contributor

arielb1 commented Mar 12, 2016

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 12, 2016

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Mar 12, 2016

📌 Commit 27217e5 has been approved by arielb1

@eddyb
Copy link
Member Author

eddyb commented Mar 12, 2016

@bors p=10000 Apparently this test is preventing other PRs from landing. Amazing how we got there in the first place.

@eddyb
Copy link
Member Author

eddyb commented Mar 12, 2016

@bors r+ force

@bors
Copy link
Collaborator

bors commented Mar 12, 2016

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Mar 12, 2016

📌 Commit 27217e5 has been approved by eddyb

@bors
Copy link
Collaborator

bors commented Mar 12, 2016

⌛ Testing commit 27217e5 with merge 8788ffc...

bors added a commit that referenced this pull request Mar 12, 2016
Statically link run-pass/command-before-exec so it passes not just whenever we happen to bootstrap perfectly.
@bors bors merged commit 27217e5 into rust-lang:master Mar 12, 2016
@eddyb eddyb deleted the stage1-is-useful-mkay branch March 12, 2016 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants