-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Statically link run-pass/command-before-exec so it passes not just whenever we happen to bootstrap perfectly. #32193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @rust-lang/tools This would probably not be a problem with |
@bors r+ |
📌 Commit 5b7f430 has been approved by |
A fix I also suggested to @pnkfelix would be to just tag this with |
|
@Manishearth What, the test is broken even at stage2?! |
sigh reproduced locally. Time to use EDIT: It appears to be the same parallelism nonsense I hit in #32080. EDIT2: Could also be bootstrapping failing to produce the same symbols. |
…enever we happen to bootstrap perfectly.
5b7f430
to
27217e5
Compare
@bors r+ |
📌 Commit 27217e5 has been approved by |
@bors r+ |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit 27217e5 has been approved by |
@bors p=10000 Apparently this test is preventing other PRs from landing. Amazing how we got there in the first place. |
@bors r+ force |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit 27217e5 has been approved by |
Statically link run-pass/command-before-exec so it passes not just whenever we happen to bootstrap perfectly.
No description provided.