Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjustments to the panic hook API #32282

Merged
merged 3 commits into from
Mar 18, 2016
Merged

Adjustments to the panic hook API #32282

merged 3 commits into from
Mar 18, 2016

Conversation

sfackler
Copy link
Member

Rename set_handler and take_handler to set_hook and take_hook since we're not actually "handling" (i.e. fixing) anything.

Also alter set_hook to take a Box<Fn(&PanicInfo) + 'static + Sync + Send> rather than a parameterized closure since there's otherwise no easy way to re-register a hook that came from take_hook.

cc #30449

r? @aturon

sfackler added 3 commits March 15, 2016 20:51
@sfackler
Rename panic handlers to panic hook
159eae8
@sfackler
Make set_hook take a Box<Fn>
157e1bc 
Otherwise there's no good way of re-registering a hook you got out of
take_hook.
@sfackler
Update rpass tests for panic hooks
50fda1e
@alexcrichton
Copy link
Member

⚓

@alexcrichton alexcrichton added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 16, 2016
@alexcrichton
Copy link
Member

The libs team discussed this yesterday and the conclusion was to merge this, the naming seems more accurate and the requirement of Box, while not the most ergonomic, reduces the unnecessary allocations at runtime and this should be a rarely used API anyway.

@bors: r+ 50fda1e

@bors
Copy link
Contributor

bors commented Mar 18, 2016

⌛ Testing commit 50fda1e with merge 24bb607...

bors added a commit that referenced this pull request Mar 18, 2016
@bors
Auto merge of #32282 - sfackler:panic-hook, r=alexcrichton
24bb607 
Adjustments to the panic hook API

Rename `set_handler` and `take_handler` to `set_hook` and `take_hook` since we're not actually "handling" (i.e. fixing) anything.

Also alter `set_hook` to take a `Box<Fn(&PanicInfo) + 'static + Sync + Send>` rather than a parameterized closure since there's otherwise no easy way to re-register a hook that came from `take_hook`.

cc #30449

r? @aturon
@bors
Copy link
Contributor

bors commented Mar 18, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild

@bors bors mentioned this pull request Mar 18, 2016
Merged
@bors bors merged commit 50fda1e into rust-lang:master Mar 18, 2016
@sfackler sfackler deleted the panic-hook branch November 26, 2016 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfackler @alexcrichton @bors @aturon