Resolve: improve diagnostics for duplicate definitions and imports #32284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jseyfried
force-pushed
the
name_conflict_diagnostics
branch
from
06b5343 to
2b70c17
Compare
jseyfried
force-pushed
the
name_conflict_diagnostics
branch
from
2b70c17 to
b3c6265
Compare
|
@bors r+ Nice! |
|
📌 Commit b3c6265 has been approved by |
|
⌛ Testing commit b3c6265 with merge 27db693... |
|
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
|
@bors: retry On Wed, Mar 16, 2016 at 2:20 PM, bors notifications@github.com wrote:
|
bors
added a commit
that referenced
this pull request
Mar 16, 2016
Resolve: improve diagnostics for duplicate definitions and imports This PR improves and regularizes the diagnostics for duplicate definitions and imports. After this PR, the second of two duplicate definitions/imports will have the following form: > a(n) [value|type|module|trait|extern crate] named \`*name*\` has already been [defined|imported] in this [module|block|trait|enum] with a note referencing this first of the two duplicate definitions/imports: > previous [definition|import] of \`*name*\` here The error indices remain unchanged. r? @eddyb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves and regularizes the diagnostics for duplicate definitions and imports.
After this PR, the second of two duplicate definitions/imports will have the following form:
with a note referencing the first of the two duplicate definitions/imports:
The error indices remain unchanged.
r? @eddyb