Skip to content

Re-add double underscores in derive #32294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 17, 2016
Merged

Re-add double underscores in derive #32294

merged 2 commits into from
Mar 17, 2016

Conversation

@Manishearth
Copy link
Member

@Manishearth Manishearth commented Mar 16, 2016 •
edited
Loading

@durka, sanity-check, please?

Don't merge this yet, I need to add a test and test it locally.

ready for review

(fixes #32292)

@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@durka
Copy link
Contributor

durka commented Mar 16, 2016

Woo, highfive is back!

durka
durka reviewed Mar 16, 2016
View reviewed changes
src/libsyntax_ext/deriving/generic/mod.rs Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed these comments, if you care

alexcrichton
alexcrichton reviewed Mar 16, 2016
View reviewed changes
src/test/run-pass/issue-32292.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add all other deriving modes here as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@alexcrichton
Copy link
Member

@bors: r+ e63a6af5d7faaa0dd1cbfec6d43fe68ca7259329

@durka
Copy link
Contributor

durka commented Mar 17, 2016

I think this line needs to regain some underscores.

@Manishearth
Copy link
Member Author

@bors r=alexcrichton

Ah, fixed.

@bors
Copy link
Collaborator

bors commented Mar 17, 2016

📌 Commit 52e064c has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Mar 17, 2016

⌛ Testing commit 52e064c with merge b12b4e4...

bors added a commit that referenced this pull request Mar 17, 2016
@bors
Auto merge of #32294 - Manishearth:derive-fix, r=alexcrichton
b12b4e4 
Re-add double underscores in derive (fixes #32292)

@durka, sanity-check, please?

<s>Don't merge this yet, I need to add a test and test it locally.</s>

ready for review
@bors
Copy link
Collaborator

bors commented Mar 17, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild

@bors bors merged commit 52e064c into rust-lang:master Mar 17, 2016
@Manishearth Manishearth deleted the derive-fix branch December 2, 2016 19:03
@Manishearth Manishearth changed the title Re-add double underscores in derive (fixes #32292) Re-add double underscores in derive Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@aturon aturon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Warning false positive with #[derive(Hash)] in nightly

6 participants

@Manishearth @rust-highfive @durka @alexcrichton @bors @aturon