diagnostics: make paths to external items more visible #32439
Conversation
jseyfried
force-pushed
the
visible_suggestions
branch
from
c4c4f58 to
1923d1c
Compare
|
Holy cow I thought I'd never live to see the day this got implemented. Thank you @jseyfried! 🍰 |
jseyfried
force-pushed
the
visible_suggestions
branch
2 times, most recently
from
6dfa268 to
4f87af1
Compare
jseyfried
force-pushed
the
visible_suggestions
branch
from
4f87af1 to
62d6ea4
Compare
| @@ -244,6 +247,52 @@ impl CStore { | |||
| { | |||
| self.extern_mod_crate_map.borrow().get(&emod_id).cloned() | |||
| } | |||
|
|
|||
| pub fn visible_parent_map<'a>(&'a self) -> ::std::cell::RefMut<'a, DefIdMap<DefId>> { | |||
There was a problem hiding this comment.
The RefCell has to be borrowed mutably in this function and I didn't want to needlessly re-borrow it immutably before returning. This function is only used in librustc_metadata so I don't think it makes much difference.
There was a problem hiding this comment.
Could you document this function please?
jseyfried
force-pushed
the
visible_suggestions
branch
from
62d6ea4 to
82da520
Compare
| }; | ||
|
|
||
| let croot = DefId { krate: cnum, index: CRATE_DEF_INDEX }; | ||
| for child in self.crate_top_level_items(cnum) { add_child(bfs_queue, child, croot); } |
|
r+ with the nits addressed |
jseyfried
force-pushed
the
visible_suggestions
branch
3 times, most recently
from
ccc40dc to
17e8ce8
Compare
|
@nrc thanks for the feedback! I addressed your comments in the most recent commit. We should probably wait for #32293 to land before merging this since there will be non-trivial conflicts (cc @nikomatsakis). |
|
☔ The latest upstream changes (presumably #32293) made this pull request unmergeable. Please resolve the merge conflicts. |
jseyfried
force-pushed
the
visible_suggestions
branch
6 times, most recently
from
e43422e to
6ac1799
Compare
|
@jseyfried I think this can be r=nrc with |
jseyfried
force-pushed
the
visible_suggestions
branch
3 times, most recently
from
8183ec4 to
d5ea770
Compare
jseyfried
force-pushed
the
visible_suggestions
branch
from
d5ea770 to
da41e58
Compare
|
@bors r=nrc |
|
📌 Commit da41e58 has been approved by |
diagnostics: make paths to external items more visible This PR changes the reported path for an external item so that it is visible from at least one local module (i.e. it does not use any inaccessible external modules) if possible. If the external item's crate was declared with an `extern crate`, the path is guarenteed to use the `extern crate`. Fixes #23224, fixes #23355, fixes #26635, fixes #27165. r? @nrc
|
💥 Test timed out |
|
@bors force retry |
|
@bors p=1 |
|
This ended up passing all tests on bors, not sure what happened here so I'm just gonna merge manually |
This PR changes the reported path for an external item so that it is visible from at least one local module (i.e. it does not use any inaccessible external modules) if possible. If the external item's crate was declared with an
extern crate, the path is guarenteed to use theextern crate.Fixes #23224, fixes #23355, fixes #26635, fixes #27165.
r? @nrc