Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make available monomorphizations shared by CGU #32469

Merged
merged 1 commit into from
Mar 26, 2016

Conversation

nikomatsakis
Copy link
Contributor

The current setup means that all generics are local to a codegen-unit,
which means massive duplication.

The current setup means that all generics are local to a codegen-unit,
which means massive duplication.
@rust-highfive
Copy link
Collaborator

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@nikomatsakis
Copy link
Contributor Author

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned arielb1 Mar 24, 2016
@eddyb
Copy link
Member

eddyb commented Mar 24, 2016

Nice small diff. Also I wonder if this is responsible for CGU's diminishing returns (cc @alexcrichton).
@bors r+

@bors
Copy link
Contributor

bors commented Mar 24, 2016

📌 Commit 13877ac has been approved by eddyb

@jonas-schievink
Copy link
Contributor

Has this always been this way?

@alexcrichton
Copy link
Member

Oh wow, this does seem surprising! Are monomorphizations available to other codgen units though? Basically do we make the symbols public? This'll end up making binaries a little larger if so (I'm not sure how much larger, though), but perhaps worth it?

bors added a commit that referenced this pull request Mar 26, 2016
Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 26, 2016
make available monomorphizations shared by CGU

The current setup means that all generics are local to a codegen-unit,
which means massive duplication.
bors added a commit that referenced this pull request Mar 26, 2016
Rollup of 11 pull requests

- Successful merges: #32131, #32199, #32257, #32325, #32435, #32447, #32448, #32456, #32469, #32476, #32482
- Failed merges: #32240
@bors bors merged commit 13877ac into rust-lang:master Mar 26, 2016
@nikomatsakis nikomatsakis deleted the shared-cgu branch March 30, 2016 16:17
@mbrubeck mbrubeck mentioned this pull request May 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants