-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make available monomorphizations shared by CGU #32469
Conversation
The current setup means that all generics are local to a codegen-unit, which means massive duplication.
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
r? @eddyb |
Nice small diff. Also I wonder if this is responsible for CGU's diminishing returns (cc @alexcrichton). |
📌 Commit 13877ac has been approved by |
Has this always been this way? |
Oh wow, this does seem surprising! Are monomorphizations available to other codgen units though? Basically do we make the symbols public? This'll end up making binaries a little larger if so (I'm not sure how much larger, though), but perhaps worth it? |
make available monomorphizations shared by CGU The current setup means that all generics are local to a codegen-unit, which means massive duplication.
The current setup means that all generics are local to a codegen-unit,
which means massive duplication.