Skip to content

Conversation

xtian
Copy link
Contributor

@xtian xtian commented Mar 25, 2016

The link to an .editorconfig file added in #24948 no longer works.

If this link should point somewhere else or just be removed, please let me know.

Thanks!

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@bors
Copy link
Collaborator

bors commented Mar 26, 2016

☔ The latest upstream changes (presumably #32508) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton
Copy link
Member

Ah looks like this was a dupe of #32470, but thanks for the PR!

bors added a commit that referenced this pull request Apr 8, 2017
[WIP] LLVM 4.0 Upgrade

Since nobody has done this yet, I decided to get things started:

**Todo:**

* [ ] push the relevant commits to `rust-lang/llvm` and `rust-lang/compiler-rt`
* [ ] cleanup `.gitmodules`
* [ ] Verify if there are any other commits from `rust-lang/llvm` which need backporting
* [x] Investigate / fix debuginfo ("`<optimized out>`") failures
* [x] Use correct emscripten version in docker image

---

Closes #37609.

---

**Test results:**

* `FAIL`: `IMAGE=armhf-gnu` [travis](https://travis-ci.org/rust-lang/rust/jobs/205860539) (looks to be qemu related, or rather the client / server tools)
* `FAIL`: `IMAGE=emscripten` [travis](https://travis-ci.org/rust-lang/rust/jobs/205978867) (with an updated emcc: one bad emcc optimization: emscripten-core/emscripten-fastcomp#176) ~~[travis](https://travis-ci.org/rust-lang/rust/jobs/205860559) (mainly (only?) due to emcc / rust llvm version mismatch)~~
* `FAIL`: `IMAGE=dist-powerpc64-linux` [travis](https://travis-ci.org/rust-lang/rust/jobs/206514546) (llvm unreachable when compiling core: `Invalid PPC CTR loop!
UNREACHABLE executed at .../PPCCTRLoops.cpp:722!`, reported as [upstream bug #32485](https://bugs.llvm.org//show_bug.cgi?id=32485))
* `SUCCESS/TIMEOUT`: `IMAGE=dist-arm-linux` [travis](https://travis-ci.org/rust-lang/rust/jobs/206514540) (passes locally)
* `SUCCESS/TIMEOUT`: `IMAGE=dist-armv7-aarch64-linux` [travis](https://travis-ci.org/rust-lang/rust/jobs/206514541) (passes locally)
* `SUCCESS`: `IMAGE=arm-android` (fixed)
* `SUCCESS`: `IMAGE=cross`
* `SUCCESS`: `IMAGE=linux-tested-targets`
* `SUCCESS`: `IMAGE=dist-android`
* `SUCCESS`: `IMAGE=dist-freebsd` (fixed)
* `SUCCESS`: `IMAGE=dist-fuchsia`
* `SUCCESS`: `IMAGE=dist-mips-linux`
* `SUCCESS`: `IMAGE=dist-mips64-linux`
* `SUCCESS`: `IMAGE=dist-powerpc-linux`
* `SUCCESS`: `IMAGE=dist-s390x-linux-netbsd` (fixed)
* `SUCCESS`: `IMAGE=dist-x86-linux` (fixed)
* `SUCCESS`: `IMAGE=i686-gnu`
* `SUCCESS`: `IMAGE=i686-gnu-nopt`
* `SUCCESS`: `IMAGE=x86_64-gnu-llvm-3.7`
* `SUCCESS`: `IMAGE=x86_64-gnu`
* `SUCCESS`: `IMAGE=x86_64-gnu-aux`
* `SUCCESS`: `IMAGE=x86_64-gnu-debug`
* `SUCCESS`: `IMAGE=x86_64-gnu-nopt`
* `SUCCESS`: `IMAGE=x86_64-gnu-full-bootstrap`
* `SUCCESS`: `IMAGE=x86_64-gnu-distcheck`
* `SUCCESS`: `IMAGE=x86_64-gnu-incremental`
bors added a commit that referenced this pull request Apr 14, 2017
LLVM 4.0 Upgrade

Since nobody has done this yet, I decided to get things started:

**Todo:**

* [ ] push the relevant commits to `rust-lang/llvm` and `rust-lang/compiler-rt`
* [ ] cleanup `.gitmodules`
* [ ] Verify if there are any other commits from `rust-lang/llvm` which need backporting
* [x] Investigate / fix debuginfo ("`<optimized out>`") failures
* [x] Use correct emscripten version in docker image

---

Closes #37609.

---

**Test results:**

* `FAIL`: `IMAGE=armhf-gnu` [travis](https://travis-ci.org/rust-lang/rust/jobs/205860539) (looks to be qemu related, or rather the client / server tools)
* `FAIL`: `IMAGE=emscripten` [travis](https://travis-ci.org/rust-lang/rust/jobs/205978867) (with an updated emcc: one bad emcc optimization: emscripten-core/emscripten-fastcomp#176) ~~[travis](https://travis-ci.org/rust-lang/rust/jobs/205860559) (mainly (only?) due to emcc / rust llvm version mismatch)~~
* `FAIL`: `IMAGE=dist-powerpc64-linux` [travis](https://travis-ci.org/rust-lang/rust/jobs/206514546) (llvm unreachable when compiling core: `Invalid PPC CTR loop!
UNREACHABLE executed at .../PPCCTRLoops.cpp:722!`, reported as [upstream bug #32485](https://bugs.llvm.org//show_bug.cgi?id=32485))
* `SUCCESS/TIMEOUT`: `IMAGE=dist-arm-linux` [travis](https://travis-ci.org/rust-lang/rust/jobs/206514540) (passes locally)
* `SUCCESS/TIMEOUT`: `IMAGE=dist-armv7-aarch64-linux` [travis](https://travis-ci.org/rust-lang/rust/jobs/206514541) (passes locally)
* `SUCCESS`: `IMAGE=arm-android` (fixed)
* `SUCCESS`: `IMAGE=cross`
* `SUCCESS`: `IMAGE=linux-tested-targets`
* `SUCCESS`: `IMAGE=dist-android`
* `SUCCESS`: `IMAGE=dist-freebsd` (fixed)
* `SUCCESS`: `IMAGE=dist-fuchsia`
* `SUCCESS`: `IMAGE=dist-mips-linux`
* `SUCCESS`: `IMAGE=dist-mips64-linux`
* `SUCCESS`: `IMAGE=dist-powerpc-linux`
* `SUCCESS`: `IMAGE=dist-s390x-linux-netbsd` (fixed)
* `SUCCESS`: `IMAGE=dist-x86-linux` (fixed)
* `SUCCESS`: `IMAGE=i686-gnu`
* `SUCCESS`: `IMAGE=i686-gnu-nopt`
* `SUCCESS`: `IMAGE=x86_64-gnu-llvm-3.7`
* `SUCCESS`: `IMAGE=x86_64-gnu`
* `SUCCESS`: `IMAGE=x86_64-gnu-aux`
* `SUCCESS`: `IMAGE=x86_64-gnu-debug`
* `SUCCESS`: `IMAGE=x86_64-gnu-nopt`
* `SUCCESS`: `IMAGE=x86_64-gnu-full-bootstrap`
* `SUCCESS`: `IMAGE=x86_64-gnu-distcheck`
* `SUCCESS`: `IMAGE=x86_64-gnu-incremental`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants