check constants even if they are not used in the current crate #32644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -17,7 +17,8 @@ impl std::ops::Neg for S { | |||
| } | |||
|
|
|||
| const _MAX: usize = -1; | |||
| //~^ ERROR unary negation of unsigned integer | |||
| //~^ WARN unary negation of unsigned integer | |||
| //~| ERROR unary negation of unsigned integer | |||
There was a problem hiding this comment.
This is odd - we shouldn't get a warning and an error
There was a problem hiding this comment.
Well... we can turn the lint into a deny-by-default lint and then we'd never reach the error
|
r+ with the make tidy issues fixed. |
oli-obk
force-pushed
the
check_all_constants_early
branch
from
d22bf20 to
aa573a8
Compare
|
fixed |
|
@bors: r+ |
|
📌 Commit aa573a8 has been approved by |
|
☔ The latest upstream changes (presumably #32562) made this pull request unmergeable. Please resolve the merge conflicts. |
oli-obk
force-pushed
the
check_all_constants_early
branch
from
aa573a8 to
913a2b4
Compare
|
rebased |
|
@bors: r+ |
|
📌 Commit 913a2b4 has been approved by |
|
⌛ Testing commit 913a2b4 with merge 6a3b558... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now this is just a
warn-by-default lint. I suggest to make it adeny-by-default lint in the next release cycle (so no dependencies break), and then in another release cycle move to an error.cc #19265
cc #3170