Rollup of 12 pull requests #32772
Closed
Rollup of 12 pull requests #32772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(1) `x` can be used in main() after the call to spawn(). Because the variables follow normal move semantics, though the keyword `move` is used, and i32 implements `Copy`. (2) I remove this sentence because the previous sentence gives the referrence to `move closures`, and more description of `move` may be redundant.
No more lifetimes in function types after rust-lang@f945190
Conflicts: src/doc/book/concurrency.md
1. In the English/Japanese phrases example in the "Multiple File Crates" section of the "Crates and Modules" chapter, there are a total of 8 module files that Rust looks for, while only four were listed. This commit lists all 8 explicitly. 2. Title case fix.
This was the original intention :(
doc: there is no case that is shown, so something was likely missing … …from the change
…abnik Mention that it's not actually a data race The example can't cause a data race since different indices are accesed. (perhaps we should use an example where i iterates twice?) r? @steveklabnik
Minor doc fixes in "Crates and Modules" and "Lifetimes" chapters These commits fix a couple of (minor) issues in the _Crates and Modules_ and the _Lifetimes_ chapters of the book. r? @steveklabnik
…assert, r=eddyb Fix LLVM assert when handling bad intrinsic monomorphizations Passing an invalid type to certain intrinsics would trigger an LLVM assert even though the invalid type was caught by the compiler. r? @eddyb
…lexcrichton Address FIXMEs related to short lifetimes in `HashMap`. None
Remove error description of `move` (1) `x` can be used in main() after the call to spawn(). Because the variables follow normal move semantics, though the keyword `move` is used, and i32 implements `Copy`. (2) I remove this sentence because the previous sentence gives the referrence to `move closures`, and more description of `move` may be redundant.
Indicate `None` is code-like in doc comment.
Remove outdated comment The corresponding code was removed in rust-lang#31824. Also remove code duplication and rename the function.
minor: update old comments No more lifetimes in function types after rust-lang@f945190
Add example doc for ToOwned trait Fixes rust-lang#29342. r? @steveklabnik
avoid "==" in assert! when one of the values is a bool Is suspect this is something of an idiom
…ng-cycle, r=eddyb change constant patterns to have a warning cycle This was the original intention :( r? @eddyb
|
@bors: r+ p=1 |
|
📌 Commit 1e4a0d0 has been approved by |
|
r? @Manishearth (rust_highfive has picked a reviewer for you, use r? to override) |
|
⌛ Testing commit 1e4a0d0 with merge 50db636... |
|
💔 Test failed - auto-win-msvc-64-opt-mir |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HashMap. #32668, Remove error description ofmove#32679, IndicateNoneis code-like in doc comment. #32691, Remove outdated comment #32724, minor: update old comments #32727, Add example doc for ToOwned trait #32744, avoid "==" in assert! when one of the values is a bool #32761, change constant patterns to have a warning cycle #32766