Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialize Extend to append for {LinkedList, Vec} #32851

Merged
merged 1 commit into from
Apr 15, 2016
Merged

Specialize Extend to append for {LinkedList, Vec} #32851

merged 1 commit into from
Apr 15, 2016

Conversation

apasel422
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

Neat! Could you also add a few tests exercising these cases specifically just to make sure we have coverage in some fashion?

@apasel422
Copy link
Contributor Author

Updated with tests.

@alexcrichton
Copy link
Member

@bors: r+ cb9d4f7483b069f686fb6917c2863920c35e675b

@bors
Copy link
Contributor

bors commented Apr 11, 2016

⌛ Testing commit cb9d4f7 with merge a103683...

@bors
Copy link
Contributor

bors commented Apr 11, 2016

⛄ The build was interrupted to prioritize another pull request.

@apasel422
Copy link
Contributor Author

@bors: retry

@apasel422
Copy link
Contributor Author

@alexcrichton Any idea what's going on with bors?

@alexcrichton
Copy link
Member

I think bors is just being a little slow, this is in the queue though

@bors
Copy link
Contributor

bors commented Apr 14, 2016

⌛ Testing commit cb9d4f7 with merge 336a3fb...

@bors
Copy link
Contributor

bors commented Apr 14, 2016

⛄ The build was interrupted to prioritize another pull request.

@alexcrichton
Copy link
Member

I interrupted this to hopefully push #32944 through which can help us cache LLVM a little more aggressively and this hadn't gone for too long just yet, bors should return back soon though!

@bors
Copy link
Contributor

bors commented Apr 14, 2016

⌛ Testing commit cb9d4f7 with merge 3623ea4...

@bors
Copy link
Contributor

bors commented Apr 14, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@apasel422
Copy link
Contributor Author

Updated to hide trait docs.

@alexcrichton
Copy link
Member

@bors: r+ cf37af1

@bors
Copy link
Contributor

bors commented Apr 14, 2016

⌛ Testing commit cf37af1 with merge 6822519...

@bors
Copy link
Contributor

bors commented Apr 14, 2016

💔 Test failed - auto-win-msvc-64-cargotest

@alexcrichton
Copy link
Member

@bors: retry

On Thu, Apr 14, 2016 at 10:58 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-win-msvc-64-cargotest
http://buildbot.rust-lang.org/builders/auto-win-msvc-64-cargotest/builds/59


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#32851 (comment)

@bors
Copy link
Contributor

bors commented Apr 14, 2016

⌛ Testing commit cf37af1 with merge 0648bc4...

@bors
Copy link
Contributor

bors commented Apr 14, 2016

💔 Test failed - auto-win-msvc-64-cargotest

@alexcrichton
Copy link
Member

@bors: retry

On Thu, Apr 14, 2016 at 12:18 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-win-msvc-64-cargotest
http://buildbot.rust-lang.org/builders/auto-win-msvc-64-cargotest/builds/64


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#32851 (comment)

@bors
Copy link
Contributor

bors commented Apr 15, 2016

⌛ Testing commit cf37af1 with merge a7b5d69...

bors added a commit that referenced this pull request Apr 15, 2016
Specialize `Extend` to `append` for `{LinkedList, Vec}`
@bors bors merged commit cf37af1 into rust-lang:master Apr 15, 2016
@apasel422 apasel422 deleted the spec-extend branch April 15, 2016 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants