Review fixes for #32878 #32880
Merged
Review fixes for #32878 #32880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors delegate=GuillaumeGomez |
|
✌️ @GuillaumeGomez can now approve this pull request |
|
|
||
| ```compile_fail | ||
| #![feature(specialization)] | ||
|
|
||
| trait SpaceLama { | ||
| trait SpaceLlama { |
There was a problem hiding this comment.
Llama is the animal, Lama is the Buddhist monk 😄
There was a problem hiding this comment.
This is how rust improves every day 🌞
There was a problem hiding this comment.
@bluss: Well, I invite you to take a look at my previous error explanations/test cases PRs then. :p
|
@bors: r+ p=10 force |
|
📌 Commit 69095bb has been approved by |
bors
added a commit
that referenced
this pull request
Apr 11, 2016
Review fixes for #32878 This contains review fixes for the PR.
|
(Moving it up in the queue because homu breaks on direct pushes anyway, so best get this out of the way) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#32878 was accidentally committed directly to master due to use of the GH interface edit button.
This contains review fixes for the PR.