remove "#" symbols to make the code compile #32973
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors: r+ rollup to be clear, the |
|
📌 Commit f916491 has been approved by |
| let f = factory(); | ||
|
|
||
| let answer = f(1); | ||
| assert_eq!(6, answer); | ||
| # } | ||
| } |
There was a problem hiding this comment.
Sorry to comment when this was already approved, but it'd read nicer better the main function's body was indented and there was an empty line in front of the fn.
There was a problem hiding this comment.
this is true. @kindlychung any chance you're interested in sending a second PR?
There was a problem hiding this comment.
To be honest I am a bit confused by the rollups below. Not yet very good at git. 😄
There was a problem hiding this comment.
No worries, it's a rust-specific thing. We wouldn't want to, for example, run the full test suite for a tiny change like this, so we "roll up" a bunch of them together and run the tests for them all at once.
Adding the spaces would be a totally new pull request.
On Apr 15, 2016, 18:08 -0400, Kaiyin Zhongnotifications@github.com, wrote:
Insrc/doc/book/closures.md(#32973 (comment)):
let f = factory();>>let answer = f(1);>assert_eq!(6, answer);>-# }>+}
To be honest I am a bit confused by the rollups below. Not yet very good at git. 😄
—
You are receiving this because you were mentioned.
Reply to this email directly orview it on GitHub(https://github.com/rust-lang/rust/pull/32973/files/f91649144e1e2e6b3664545cb7e117d839f9cd95#r59948089)
remove "#" symbols to make the code compile
No description provided.