std: Change String::truncate to panic less #32977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @brson |
brson
added
the
relnotes
|
@bors r+ |
|
📌 Commit 41861ed has been approved by |
|
@alexcrichton: You need to update |
The `Vec::truncate` method does not panic if the length argument is greater than the vector's current length, but `String::truncate` will indeed panic. This semantic difference can be a bit jarring (e.g. rust-lang#32717), and after some discussion the libs team concluded that although this can technically be a breaking change it is almost undoubtedly not so in practice. This commit changes the semantics of `String::truncate` to be a noop if `new_len` is greater than the length of the current string. Closes rust-lang#32717
alexcrichton
force-pushed
the
ignore-panics
branch
from
41861ed to
ae79ce3
Compare
|
⌛ Testing commit ae79ce3 with merge 20dafb0... |
|
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
|
@bors: retry On Sat, Apr 16, 2016 at 2:06 AM, bors notifications@github.com wrote:
|
|
⌛ Testing commit ae79ce3 with merge b5de94f... |
bors
added a commit
that referenced
this pull request
Apr 17, 2016
std: Change String::truncate to panic less The `Vec::truncate` method does not panic if the length argument is greater than the vector's current length, but `String::truncate` will indeed panic. This semantic difference can be a bit jarring (e.g. #32717), and after some discussion the libs team concluded that although this can technically be a breaking change it is almost undoubtedly not so in practice. This commit changes the semantics of `String::truncate` to be a noop if `new_len` is greater than the length of the current string. Closes #32717
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Vec::truncatemethod does not panic if the length argument is greater thanthe vector's current length, but
String::truncatewill indeed panic. Thissemantic difference can be a bit jarring (e.g. #32717), and after some
discussion the libs team concluded that although this can technically be a
breaking change it is almost undoubtedly not so in practice.
This commit changes the semantics of
String::truncateto be a noop ifnew_lenis greater than the length of the current string.Closes #32717