Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use "bind" to refer to both referencing and to assignment #33007

Merged
merged 1 commit into from
Apr 19, 2016
Merged

Do not use "bind" to refer to both referencing and to assignment #33007

merged 1 commit into from
Apr 19, 2016

Conversation

notriddle
Copy link
Contributor

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@notriddle
Copy link
Contributor Author

Just letting you know that the Travis CI error was from apt-get; it's not a problem with the pull request.

@steveklabnik
Copy link
Member

@bors: r+ rollup

thank you!

@bors
Copy link
Contributor

bors commented Apr 18, 2016

📌 Commit 63b5080 has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 18, 2016
@steveklabnik
Rollup merge of rust-lang#33007 - notriddle:master, r=steveklabnik
d3d9bd0 
Do not use "bind" to refer to both referencing and to assignment

See https://users.rust-lang.org/t/difference-between-four-references/5406/7
@steveklabnik steveklabnik mentioned this pull request Apr 18, 2016
Merged
bors added a commit that referenced this pull request Apr 18, 2016
@bors
Auto merge of #33081 - steveklabnik:rollup, r=steveklabnik
b324fa7 
Rollup of 6 pull requests

- Successful merges: #32558, #32906, #33007, #33008, #33035, #33058
- Failed merges: #32912
@bors bors merged commit 63b5080 into rust-lang:master Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@notriddle @rust-highfive @steveklabnik @bors