Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syntax: Parse import prefixes as paths #33044

Merged
merged 1 commit into from
Apr 17, 2016
Merged

syntax: Parse import prefixes as paths #33044

merged 1 commit into from
Apr 17, 2016

Conversation

petrochenkov
Copy link
Contributor

Fixes #10415

r? @eddyb
(This partially intersects with #33041)

eddyb
eddyb reviewed Apr 17, 2016
View reviewed changes
src/libsyntax/parse/parser.rs
@@ -81,6 +81,8 @@ type ItemInfo = (Ident, ItemKind, Option<Vec<Attribute> >);
pub enum PathParsingMode {
/// A path with no type parameters; e.g. `foo::bar::Baz`
NoTypesAllowed,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used anymore at all?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed all existing uses in #33041, but a new one is introduced in #32875
Merging these two variants into one with ImportPrefix's semantics does no harm, I guess. I'll do it as a part of #33041

@eddyb
Copy link
Member

eddyb commented Apr 17, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Apr 17, 2016

📌 Commit e7bc939 has been approved by eddyb

@Manishearth Manishearth mentioned this pull request Apr 17, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 17, 2016
@Manishearth
Rollup merge of rust-lang#33044 - petrochenkov:prefix, r=eddyb
02e40d9 
syntax: Parse import prefixes as paths

Fixes rust-lang#10415

r? @eddyb
(This partially intersects with rust-lang#33041)
bors added a commit that referenced this pull request Apr 17, 2016
@bors
Auto merge of #33049 - Manishearth:rollup, r=Manishearth
a626400 
Rollup of 10 pull requests

- Successful merges: #31441, #32956, #33003, #33022, #33023, #33032, #33039, #33044, #33045, #33046
- Failed merges:
@bors bors merged commit e7bc939 into rust-lang:master Apr 17, 2016
@jseyfried jseyfried mentioned this pull request Apr 27, 2016
Closed
@petrochenkov petrochenkov mentioned this pull request May 7, 2016
Closed
@petrochenkov petrochenkov deleted the prefix branch September 21, 2016 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petrochenkov @eddyb @bors