rustc_trans: implement lld compatibility #33327
Conversation
| if self.is_lld && self.sess.target.target.options.is_like_osx { | ||
| let mut v = OsString::from("-l"); | ||
| v.push(lib); | ||
| self.arg(&v); |
There was a problem hiding this comment.
Can this case of combining the two args just work everywhere?
There was a problem hiding this comment.
Possibly, but it really should be the other way around. This is a case of lld being noncompliant, which should be fixed upstream and then this can be reverted.
There was a problem hiding this comment.
I think what @brson is mentioning is that if this form works everywhere we should just use that instead, we didn't pick -l foo for any particular reason beyond it was easier to write for us at the time. If -lfoo works in more places, let's just change to always doing that.
rustc_back: use a common musl base extracted from #33327. cc #33189. r? @alexcrichton
rustc_back: use a common musl base extracted from #33327. cc #33189. r? @alexcrichton
|
☔ The latest upstream changes (presumably #33553) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Closing due to inactivity, but feel free to resubmit with a rebase! |
This changes the semantics of rustc_trans::link::Linker such that the underlying command can no longer be directly accessed. That's used in a later commit which implements preliminary
lldcompatibility.r? @japaric
cc @alexcrichton