Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix built-in target detection #33363

Merged
merged 3 commits into from
Jul 27, 2016
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 11 additions & 13 deletions src/librustc_back/target/mod.rs
Original file line number Diff line number Diff line change
@@ -69,20 +69,18 @@ macro_rules! supported_targets {
/// List of supported targets
pub const TARGETS: &'static [&'static str] = &[$($triple),*];

// this would use a match if stringify! were allowed in pattern position
fn load_specific(target: &str) -> Option<Target> {
let target = target.replace("-", "_");
if false { }
$(
else if target == stringify!($module) {
let mut t = $module::target();
t.options.is_builtin = true;
debug!("Got builtin target: {:?}", t);
return Some(t);
}
)*

None
match target {
$(
$triple => {
let mut t = $module::target();
t.options.is_builtin = true;
debug!("Got builtin target: {:?}", t);
Some(t)
},
)+
_ => None
}
}
)
}
5 changes: 5 additions & 0 deletions src/test/run-make/issue-33329/Makefile
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
-include ../tools.mk

all:
$(RUSTC) --target x86_64_unknown-linux-musl main.rs 2>&1 | \
grep "error: Error loading target specification: Could not find specification for target"
11 changes: 11 additions & 0 deletions src/test/run-make/issue-33329/main.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
// Copyright 2016 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

fn main() {}