rustdoc: do not strip blanket impls in crate of origin #33514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `impl<T> Trait for T`, the blanket type parameters `T` were recognized as "local" and "not exported", so these impls were thrown out. Now we check if they are generic, and keep them in that case. Fixes: rust-lang#29503
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 9, 2016
rustdoc: do not strip blanket impls in crate of origin In `impl<T> Trait for T`, the blanket type parameters `T` were recognized as "local" and "not exported", so these impls were thrown out. Now we check if they are generic, and keep them in that case. Fixes: rust-lang#29503
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 9, 2016
rustdoc: do not strip blanket impls in crate of origin In `impl<T> Trait for T`, the blanket type parameters `T` were recognized as "local" and "not exported", so these impls were thrown out. Now we check if they are generic, and keep them in that case. Fixes: rust-lang#29503
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 9, 2016
rustdoc: do not strip blanket impls in crate of origin In `impl<T> Trait for T`, the blanket type parameters `T` were recognized as "local" and "not exported", so these impls were thrown out. Now we check if they are generic, and keep them in that case. Fixes: rust-lang#29503
|
Was there another doc related change? Because part of #29503 seems to have already been fixed previously between nightly-2016-04-26 and nightly-2016-04-28. |
|
Possibly #33133 |
bluss
added
the
relnotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
impl<T> Trait for T, the blanket type parametersTwere recognized as "local" and "not exported", so these impls were thrown out.Now we check if they are generic, and keep them in that case.
Fixes: #29503