fix str::eq_slice off-by-one error #3365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I think we should merge this fix, and then reconsider the interface to as_buf. This is some confusing behavior and it looks like the only users of that len value don't actually care about the potentially extra null. |
|
Pushed to incoming. |
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Mar 9, 2024
Automatic Rustup
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Mar 9, 2024
Automatic Rustup
jaisnan
pushed a commit
to jaisnan/rust-dev
that referenced
this pull request
Jul 29, 2024
Dependency upgrade resulting from `cargo update`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
memcmp-based implementation ofstr::eq_slice(54a8d69) usesstr::as_buf, which, according to its documentation, passes one more than the real length of the string in order to facilitate null-terminator checks.eq_slicedoesn't take this into account, and compares the next byte beyond the ends of the slices it is given. For full strings, this is the null terminator, but for slices in the middle of a string, this is whatever the next UTF-8 byte is.Therefore, code like
assert str::view("foobar", 0, 3) == "foo";fails.This fix simply subtracts one from the length yielded by
as_bufin order to compensate for this.