Skip to content

true color, fixed boolval style in doc #33661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

Conversation

hoodie
Copy link
Contributor

@hoodie hoodie commented May 15, 2016

Hey, I noticed that booleans looked a bit pale in rustdoc.
Happy Birthday Rust.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@hoodie
Copy link
Contributor Author

hoodie commented May 16, 2016

how long does it usually take until travis kicks in?

@birkenfeld
Copy link
Contributor

There's another boolval in src/doc/rust.css. Why not just fix boolvalue -> boolval?

@hoodie
Copy link
Contributor Author

hoodie commented May 17, 2016

did I miss that? there is a prelude-val next to that, so I went with this naming scheme

@steveklabnik
Copy link
Member

Hey, sorry for missing out on this PR. Can you show me what this looks like with the change applied, please?

@hoodie
Copy link
Contributor Author

hoodie commented Jun 7, 2016

sure, this just fixed a regression, just compare the code examples in nightly and stable.

@hoodie
Copy link
Contributor Author

hoodie commented Jun 7, 2016

wait what? no I didn't close this 😕 I just moved it to another branch grrr

@hoodie hoodie mentioned this pull request Jun 7, 2016
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jun 7, 2016
Bug/bool colors

This is actually rust-lang#33661 @steveklabnik, sorry about this, github ate my homework
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants