Reword the short diagnostic for E0509 #33676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
|
This needs to update the test suite. (Tests will fail otherwise.) |
|
I agree. Big 👍!
True. |
hanna-kruppe
force-pushed
the
e0509-exact-words
branch
from
5aacf17 to
60fa200
Compare
|
D'oh! Can you tell it's my first time touching diagnostics? 😄 I think I updated all tests now (local build/tests not finished yet). |
|
Travis is taking its sweet time with the build, but at least |
|
Failed tidy. :( |
hanna-kruppe
force-pushed
the
e0509-exact-words
branch
from
60fa200 to
ac6da22
Compare
|
Ugh. Fixed now. |
|
@bors r+ rollup |
|
📌 Commit ac6da22 has been approved by |
|
☔ The latest upstream changes (presumably #33688) made this pull request unmergeable. Please resolve the merge conflicts. |
Saying that a type *implements* a trait is much more idiomatic than saying it *defines* the trait.
hanna-kruppe
force-pushed
the
e0509-exact-words
branch
from
ac6da22 to
e575d19
Compare
|
Rebased |
|
@bors r+ rollup |
|
📌 Commit e575d19 has been approved by |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 20, 2016
Reword the short diagnostic for E0509 Saying that a type *implements* a trait is much more idiomatic than saying it *defines* the trait.
bors
added a commit
that referenced
this pull request
May 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saying that a type implements a trait is much more idiomatic than saying it defines the trait.