Skip to content

Resolved rustdoc crash (#33678) by aborting instead of unwrapping. #33702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2016

Conversation

crimsun
Copy link

@crimsun crimsun commented May 17, 2016

Also removed Option use and comment to match.

Fixes #33678

…pping.

Removed Option use and comment to match.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cmr (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+ 59e5a5c

Thanks!

@bors
Copy link
Collaborator

bors commented May 19, 2016

⌛ Testing commit 59e5a5c with merge 2fb6f8e...

bors added a commit that referenced this pull request May 19, 2016
Resolved rustdoc crash (#33678) by aborting instead of unwrapping.

Also removed Option use and comment to match.

Fixes #33678
@bors bors merged commit 59e5a5c into rust-lang:master May 19, 2016
@crimsun crimsun deleted the pr33678 branch May 21, 2016 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants