Mutable access to the top element of a BinaryHeap #33830
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gankro (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
sfackler
added
the
T-libs-api
|
cc @rust-lang/libs |
| /// *val = 0; | ||
| /// } | ||
| /// assert_eq!(heap.peek(), Some(&2)); | ||
| /// |
moosingin3space
force-pushed
the
feature/mutable-high-priority-binaryheap
branch
2 times, most recently
from
ae75365 to
6dcf641
Compare
|
The libs team was able to discuss this PR today and the conclusion was that we'd like to merge, thanks for the PR @moosingin3space! Could you be sure to update the tracking issue for the unstable APIs as well? If you open an issue I can be sure to tag it appropriately. Once that's done you can just squash the commits and I'll r+ |
moosingin3space
force-pushed
the
feature/mutable-high-priority-binaryheap
branch
from
6dcf641 to
a51ad64
Compare
|
@alexcrichton just opened a tracking issue and rebased. |
| /// } | ||
| /// assert_eq!(heap.peek(), Some(&2)); | ||
| /// ``` | ||
| #[unstable(feature = "binary_heap_peek_mut", issue = "0")] |
There was a problem hiding this comment.
Could you update these references to issue "0" to the tracking issue instead?
moosingin3space
force-pushed
the
feature/mutable-high-priority-binaryheap
branch
from
a51ad64 to
2a34a7b
Compare
|
@alexcrichton all green and style issues fixed. |
|
⌛ Testing commit 2a34a7b with merge ce2cd27... |
|
@bors: retry force clean
|
…binaryheap, r=alexcrichton Mutable access to the top element of a BinaryHeap An implementation of the library change discussed here: rust-lang/rfcs#1626
An implementation of the library change discussed here: rust-lang/rfcs#1626