Added examples/docs to split in str.rs

[Ophirr33]

Added documentation clarifying the behavior of split when used with the empty string and contiguous separators. Addresses issue 33882. This is my first time contributing to rust, so forgive me if I'm skipping any of the contribution steps.
Fixes #33882

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gankro (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[steveklabnik]

Looks great! If you say "Fixes #33882" in your commit message, it will close the issue when this gets merged. Would you mind amending the message to put this in?

[Ophirr33]

Absolutely, just fixed that. Thanks for the heads up!

On Thu, May 26, 2016 at 6:57 PM, Steve Klabnik notifications@github.com
wrote:

Looks great! If you say "Fixes #33882
#33882" in your commit message,
it will close the issue when this gets merged. Would you mind amending the
message to put this in?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#33893 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/APLtwS5PBtuecyjXSakLVT2dSlrvBuXRks5qFiVmgaJpZM4IoBuH
.

[steveklabnik]

I am not seeing the fix, did you push it? Also, Travis seems to be failing. My internet connection is terrible, so it's not showing me why, but that has to be passing before we can merge too 😄

[Ophirr33]

I'm seeing the command "make tidy && make check-notidy -j4" exited with 2."
Does this mean I'm failing a style check in the way I formatted i?

On Thu, May 26, 2016 at 7:31 PM, Steve Klabnik notifications@github.com
wrote:

I am not seeing the fix, did you push it? Also, Travis seems to be
failing. My internet connection is terrible, so it's not showing me why,
but that has to be passing before we can merge too 😄

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#33893 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/APLtwY7DcL-HwGDm5iAMTFu25n52mruoks5qFi1CgaJpZM4IoBuH
.

[Ophirr33]

Trailing white space was the issue. I fixed the offending lines.

[tbu-]

I don't think we should commit to this weird behavior, we should probably copy some other language's standard library here.

[GuillaumeGomez]

Please squash your commits.

[Ophirr33]

Rebase doesn't seem to be doing the trick. Am I squashing incorrectly? (git newbie here)

[steveklabnik]

@Ophirr33 I wrote a blog post that might be helpful: http://blog.steveklabnik.com/posts/2012-11-08-how-to-squash-commits-in-a-github-pull-request

[Ophirr33]

Got it! Thanks again

[steveklabnik]

@bors: r+ rollup

[bors]

📌 Commit feb0b27 has been approved by steveklabnik

[bors]

⌛ Testing commit feb0b27 with merge 69da70d...

[bors]

💔 Test failed - auto-linux-64-opt-rustbuild

[GuillaumeGomez]

@bors: r+ rollup

[bors]

💡 This pull request was already approved, no need to approve it again.

• This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
• There's another pull request that is currently being tested, blocking this pull request: save-temps was moved under the -C switch #33902

[bors]

📌 Commit feb0b27 has been approved by GuillaumeGomez

[tbu-]

Maybe it is the wanted behavior. With the current results, find and split return similar things.

[GuillaumeGomez]

@bors: retry