Add error description for E0174 #33920
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -1972,6 +1972,88 @@ To learn more about traits, take a look at the Book: | |||
| https://doc.rust-lang.org/book/traits.html | |||
| "##, | |||
|
|
|||
| E0174: r##" | |||
| This error occurs because of unboxed closure explicitly methods calls is | |||
There was a problem hiding this comment.
I'm going change to the original short description error: "explicit use of unboxed closure methods are experimental"
There was a problem hiding this comment.
A bit more explicit isn't a problem. It's just badly formulated like I said.
No problem! 😃 So there are some sentences that are badly formulated and a few nits. Nothing big. Thanks for your PR! |
|
Done. :) |
| Example of erroneous code: | ||
|
|
||
| ```compile_fail | ||
| fn foo<F: Fn(&str)>(mut f: F) { |
There was a problem hiding this comment.
I just noticed: why this functions' lines have an extra blank space at the beggining?
There was a problem hiding this comment.
Ops... I didn't notice also
|
Seems good for me but I'd prefer to have a second opinion on this. Thanks for your work! :) PS: don't forget to squash your commits. |
|
For sure. Let's see what @steveklabnik says so I squash them. |
| @@ -1972,6 +1972,88 @@ To learn more about traits, take a look at the Book: | |||
| https://doc.rust-lang.org/book/traits.html | |||
| "##, | |||
|
|
|||
| E0174: r##" | |||
| This error occurs because of the explicit use of unboxed closure methods | |||
| that is an experimental feature in current Rust version. | |||
There was a problem hiding this comment.
"that are an experimental feature in this version of Rust."
cristianoliveira
force-pushed
the
error-E0174-explanation
branch
2 times, most recently
from
9c2f10c to
15fdbf0
Compare
|
Done. |
| } | ||
| ``` | ||
|
|
||
| Rust’s implementation of closures is a bit different than other languages. |
There was a problem hiding this comment.
’ seems weird for me. ' wouldn't be better in here? cc @steveklabnik
There was a problem hiding this comment.
It comes from the documentation take a look:
https://doc.rust-lang.org/book/closures.html#closure-implementation
There was a problem hiding this comment.
I'm not sure it applies here.
There was a problem hiding this comment.
I see... There is another case and they have used (').
https://github.com/rust-lang/rust/blob/master/src/librustc_typeck/diagnostics.rs#L1548
Let me change it.
|
Just a few more nits and it'll be good to go! |
cristianoliveira
force-pushed
the
error-E0174-explanation
branch
2 times, most recently
from
38dff9c to
4c3d653
Compare
|
All good, thanks! @bors: r+ rollup |
|
📌 Commit 4c3d653 has been approved by |
| Example of an implicit call: | ||
|
|
||
| ``` | ||
| fn foo<F: Fn()>(f: F) { |
There was a problem hiding this comment.
Let me fix it.
|
@bors r- |
cristianoliveira
force-pushed
the
error-E0174-explanation
branch
from
4c3d653 to
45e647d
Compare
|
Fixed |
|
@bors r=GuillaumeGomez |
|
📌 Commit 45e647d has been approved by |
|
⌛ Testing commit 45e647d with merge 4a4a13a... |
…illaumeGomez Add error description for E0174 Reference for issue: #32777 r? @GuillaumeGomez Hey Guillaume, sorry for taking too long to do it. I got some unexpected work during the week. Waiting for your review :)
Reference for issue: #32777
r? @GuillaumeGomez
Hey Guillaume, sorry for taking too long to do it. I got some unexpected work during the week.
Waiting for your review :)