Use --release-channel=stable by default on releases #33971
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
r? @brson Just to double check, you've confirmed this works locally, right? |
|
@alexcrichton Yes, I've removed the .git file and noticed the change on the default. Reviewing this change, I think this could be even better if the check happens closer to the other statement which sets the default to dev. I will do the change here and update the code if that is ok. |
bltavares
force-pushed
the
28322/default-channel-to-stable-on-tarball
branch
from
d903fbc to
f4469bb
Compare
|
Sounds reasonable to me! |
|
The build failed because it couldn't find llvm-tools. Is there a way to trigger it again? |
|
Seems ok, though as written one won't be able to change the release channel at all on tarballs. Also, existing packagers are going to get build errors in their existing scripts because |
|
I was able to test it locally, and this change will not break the current interface. It is still possible to change the release channel when it is a tarball extraction. Here are the tests I did: |
|
Oh, indeed. I misread the patch. @bors r+ |
|
📌 Commit f4469bb has been approved by |
|
⌛ Testing commit f4469bb with merge 43ce274... |
|
💔 Test failed - auto-linux-64-cross-armhf |
|
The failure seems to be unrelated to the change. It failed on the Is it possible to trigger the test again? On May 31, 2016 7:48:28 PM GMT-03:00, bors notifications@github.com wrote:
Sent from my Android device with K-9 Mail. Please excuse my brevity. |
|
@bors: retry On Tue, May 31, 2016 at 4:09 PM, Bruno Lara Tavares <
|
|
Travis fails |
bltavares
force-pushed
the
28322/default-channel-to-stable-on-tarball
branch
from
f4469bb to
6ceb42d
Compare
|
@Manishearth Travis is failing because LLVM APT repository has been turned off temporarily Accessing http://llvm.org/apt/, we are welcome with the following message: |
|
Triaging this error further, for documentation: There is an announcement on the LLVM list that the APT source has been disabled This mean that every Travis CI build on Pull Requests will fail until the repo is back online. I've tried a few alternatives locally to unblock this, without much success. 1- Download the precompiled Ubuntu Trusty dist from llvm.org 2- Download llvm-3.7-tools from Ubuntu Willy manually 3- Add Ubuntu Wily APT repository So far it has been the best short term option. I will open a pull request with the change to further discuss that. |
> Release tarballs should be compilable with just basic ./configure ; > make ; sudo make install without having to pass special flags to > configure. This is the case of the --release-channel option, that must > be changed in the releases. This commit detects the presence of .git, as it happens on other parts of `configure` to assume it is a tarball. Then it changes the default value stored, before parsing the arguments, while still allowing it to be overriden before any action verifying the flag is done. Closes rust-lang#28322
bltavares
force-pushed
the
28322/default-channel-to-stable-on-tarball
branch
from
6ceb42d to
970f8d8
Compare
|
Rebasing with upstream to get the changes Travis configuration changes. |
|
@bors r+ |
|
📌 Commit 970f8d8 has been approved by |
|
⌛ Testing commit 970f8d8 with merge 3265bd5... |
…arball, r=brson Use --release-channel=stable by default on releases > Release tarballs should be compilable with just basic ./configure ; > make ; sudo make install without having to pass special flags to > configure. This is the case of the --release-channel option, that must > be changed in the releases. This commit detects the presence of .git, as it happens on other parts of `configure` to assume it is a tarball. Then it changes the default value stored, before parsing the arguments, while still allowing it to be overriden before any action verifying the flag is done. Closes #28322
This commit detects the presence of .git, as it happens on other parts
of
configureto assume it is a tarball. Then it changes the defaultvalue stored, before parsing the arguments, while still allowing it to
be overriden before any action verifying the flag is done.
Closes #28322