Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document that Files close themselves automatically #33993

Merged
merged 2 commits into from
Jun 2, 2016

Conversation

oconnor663
Copy link
Contributor

No description provided.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Thanks for the PR! We may actually one day add a close method, so perhaps this could just be shortened to indicating that files are closed when they go out of scope?

@oconnor663
Copy link
Contributor Author

Interesting! Something like fn close(self) -> io::Result<()>?

@alexcrichton
Copy link
Member

@bors: r+ df8d5ba rollup

Perhaps, yeah, although the actual self argument may be tweaked (e.g. take &mut self instead)

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 2, 2016
document that Files close themselves automatically
bors added a commit that referenced this pull request Jun 2, 2016
Rollup of 7 pull requests

- Successful merges: #33993, #34013, #34014, #34015, #34019, #34021, #34033
- Failed merges:
@bors bors merged commit df8d5ba into rust-lang:master Jun 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants