Don't generate #[doc(hidden)] elements #34026
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
force-pushed
the
doc_hidden
branch
from
0cb827a
to
32ec32f
Compare
GuillaumeGomez
force-pushed
the
doc_hidden
branch
from
32ec32f
to
4ea7bc9
Compare
|
|
||
| // @has issue_15347/fn.foo.html | ||
| #[doc(hidden)] | ||
| pub fn foo() {} |
There was a problem hiding this comment.
I don't think this test should be deleted. From #15347 it seems that these compile flags are supposed to result in this file existing, with actual content (whereas this PR is removing empty files for hidden docs).
There was a problem hiding this comment.
The thing here is that the foo function is the only item and is specified as hidden. So we have nothing to generate. If I understood correctly, #15347 was about creating doc for private items, not hidden ones.
|
Closing it in favor of #34045. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34025.
r? @brson